Facing configuration on Android (on take picture). #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification should allow to configure camerafacing on take picture.
ghost
added
the
Contributor
|
Hi @ximbor Thanks for contributing to nativescript-camera plugin! @DimitarTachev and I revewed you PR and have a question what more it adds to the existing functionality. Is it solving an issue or it is just a clearer way to present the option in the code? Also, please re-base your branch, cause it is out-of-date and we need this done in order to merge. Thanks, |
DimitarTachev
approved these changes
Dec 19, 2017
Author
|
Hi Veselina,
In Readme.md (in CameraOptions section), it's reported the following item:
cameraFacing rear The initial camera facing. Use 'front' for selfies.
but the "cameraFacing" parameter didn't seem to be managed inside the
takePicture method, in fact the "options" object didn't affect the
behavior of takePicture function, as only the following parameters were
persisted inside the function:
saveToGallery = options.saveToGallery ? true : false;
reqWidth = options.width ? options.width * density : 0;
reqHeight = options.height ? options.height * density : reqWidth;
shouldKeepAspectRatio = types.isNullOrUndefined(options.keepAspectRatio) ?
true : options.keepAspectRatio;
Hope this could help...
Thanks,
Simone
2017-12-19 10:00 GMT+01:00 radeva <notifications@github.com>:
… Hi @ ximbor
Thanks for contributing to nativescript-camera plugin! @DimitarTachev
<https://github.com/dimitartachev> and I revewed you PR and have a
question what more it adds to the existing functionality. Is it solving an
issue or it is just a clearer way to present the option in the code?
Also, please re-base your branch, cause it is out-of-date and we need this
done in order to merge.
Thanks,
Veselina
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVlZkvlf3PXCPa4D6DaHX0ts4_wmE2l5ks5tB3sXgaJpZM4Q4ldG>
.
|
Contributor
|
I'm closing this in favor of #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification should allow to configure camerafacing on take
picture.